Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: Support documentation and comments like postman #3964

Open
1 task done
kirito41dd opened this issue Apr 7, 2024 · 7 comments
Open
1 task done

[feature]: Support documentation and comments like postman #3964

kirito41dd opened this issue Apr 7, 2024 · 7 comments
Labels
feature New feature or request

Comments

@kirito41dd
Copy link

kirito41dd commented Apr 7, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Summary

image

Why should this be worked on?

If there is a place to write documents or comments, collaborators can get more helpful information

@kirito41dd kirito41dd added the feature New feature or request label Apr 7, 2024
@CharkiAbdelillah
Copy link

CharkiAbdelillah commented Apr 7, 2024

@kirito41dd hey
pls are you using Hoppscotch as a self-Host?

@kirito41dd
Copy link
Author

kirito41dd commented Apr 8, 2024

@CharkiAbdelillah yes,I use the docker all-in-one method in the official documentation to deploy.

@CharkiAbdelillah
Copy link

@kirito41dd i use the same method but still facing a problem in the admin UI can you help me pls?

@kirito41dd
Copy link
Author

@CharkiAbdelillah

  1. I used config ENABLE_SUBPATH_BASED_ACCESS=true, and some related configuration changes
  2. I changed the code for http env
--- a/packages/hoppscotch-backend/src/auth/helper.ts
+++ b/packages/hoppscotch-backend/src/auth/helper.ts
@@ -62,13 +62,13 @@ export const authCookieHandler = (

   res.cookie(AuthTokenType.ACCESS_TOKEN, authTokens.access_token, {
     httpOnly: true,
-    secure: true,
+    secure: false,
     sameSite: 'lax',
     maxAge: accessTokenValidity,
   });
   res.cookie(AuthTokenType.REFRESH_TOKEN, authTokens.refresh_token, {
     httpOnly: true,
-    secure: true,
+    secure: false,
     sameSite: 'lax',
     maxAge: refreshTokenValidity,
   });

That's all

@CharkiAbdelillah
Copy link

thanks @kirito41dd for your reply
but even i did secure: false, when im trying to login to admin dashboard through github it redirects me to the same page of login!

@CharkiAbdelillah
Copy link

@kirito41dd By the way im working locally

@kirito41dd
Copy link
Author

@CharkiAbdelillah Debug the oauth process, check 302 location is right.

It's OT to discuss this topic here.

May be you can find help in Discussions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants