From 8fdba760a24a8fdd578f29ac10f3a5c656126784 Mon Sep 17 00:00:00 2001 From: Nivedin <53208152+nivedin@users.noreply.github.com> Date: Wed, 13 Mar 2024 14:21:23 +0530 Subject: [PATCH] refactor: personal workspace nomenclature update (#3893) Co-authored-by: jamesgeorge007 --- packages/hoppscotch-common/locales/en.json | 1 - .../src/components/app/Header.vue | 11 +++------- .../src/components/workspace/Current.vue | 20 +++---------------- .../src/components/workspace/Selector.vue | 8 +------- 4 files changed, 7 insertions(+), 33 deletions(-) diff --git a/packages/hoppscotch-common/locales/en.json b/packages/hoppscotch-common/locales/en.json index 905844c33f..8017fdadfa 100644 --- a/packages/hoppscotch-common/locales/en.json +++ b/packages/hoppscotch-common/locales/en.json @@ -988,7 +988,6 @@ "workspace": { "change": "Change workspace", "personal": "Personal Workspace", - "personal_workspace": "{name}'s Workspace", "other_workspaces": "My Workspaces", "team": "Workspace", "title": "Workspaces" diff --git a/packages/hoppscotch-common/src/components/app/Header.vue b/packages/hoppscotch-common/src/components/app/Header.vue index dbe1a5c34c..55557f960d 100644 --- a/packages/hoppscotch-common/src/components/app/Header.vue +++ b/packages/hoppscotch-common/src/components/app/Header.vue @@ -331,14 +331,9 @@ const myTeams = useReadonlyStream(teamListAdapter.teamList$, null) const workspace = workspaceService.currentWorkspace const workspaceName = computed(() => { - if (workspace.value.type === "personal") { - return currentUser.value?.displayName - ? t("workspace.personal_workspace", { - name: currentUser.value.displayName, - }) - : t("workspace.personal") - } - return workspace.value.teamName + return workspace.value.type === "personal" + ? t("workspace.personal") + : workspace.value.teamName }) const refetchTeams = () => { diff --git a/packages/hoppscotch-common/src/components/workspace/Current.vue b/packages/hoppscotch-common/src/components/workspace/Current.vue index f756e7311d..5b3d01ae12 100644 --- a/packages/hoppscotch-common/src/components/workspace/Current.vue +++ b/packages/hoppscotch-common/src/components/workspace/Current.vue @@ -15,8 +15,6 @@ import { computed } from "vue" import { useI18n } from "~/composables/i18n" import { useService } from "dioc/vue" import { WorkspaceService } from "~/services/workspace.service" -import { useReadonlyStream } from "~/composables/stream" -import { platform } from "~/platform" const props = defineProps<{ section?: string @@ -28,23 +26,11 @@ const t = useI18n() const workspaceService = useService(WorkspaceService) const workspace = workspaceService.currentWorkspace -const currentUser = useReadonlyStream( - platform.auth.getProbableUserStream(), - platform.auth.getProbableUser() -) - const currentWorkspace = computed(() => { - const personalWorkspaceName = currentUser.value?.displayName - ? t("workspace.personal_workspace", { name: currentUser.value.displayName }) - : t("workspace.personal") - - if (props.isOnlyPersonal) { - return personalWorkspaceName - } - if (workspace.value.type === "team") { - return teamWorkspaceName.value + if (props.isOnlyPersonal || workspace.value.type === "personal") { + return t("workspace.personal") } - return personalWorkspaceName + return teamWorkspaceName.value }) const teamWorkspaceName = computed(() => { diff --git a/packages/hoppscotch-common/src/components/workspace/Selector.vue b/packages/hoppscotch-common/src/components/workspace/Selector.vue index 0ab57c2d3b..0b11c68e57 100644 --- a/packages/hoppscotch-common/src/components/workspace/Selector.vue +++ b/packages/hoppscotch-common/src/components/workspace/Selector.vue @@ -3,7 +3,7 @@
- currentUser.value?.displayName - ? t("workspace.personal_workspace", { name: currentUser.value.displayName }) - : t("workspace.personal") -) - const workspaceService = useService(WorkspaceService) const teamListadapter = workspaceService.acquireTeamListAdapter(null) const myTeams = useReadonlyStream(teamListadapter.teamList$, [])