Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Chrome extension loses origin list after Chrome restart or backend upgrade #269

Open
tomerr-ma opened this issue Feb 6, 2024 · 3 comments

Comments

@tomerr-ma
Copy link

We have noticed that sometimes (seems to be correlated with version upgrades of the hoppscotch backend version), we lost the Hoppscotch URL in the Chrome extension.

@tomerr-ma
Copy link
Author

tomerr-ma commented Mar 11, 2024

We Also see it happens also in Chrome restart and not necessarily when upgrading version which is more severe. happens also on version 0.31

@tomerr-ma tomerr-ma changed the title [bug]: Chrome extension loses origin list after backend upgrade [bug]: Chrome extension loses origin list after Chrome restart or backend upgrade Mar 11, 2024
@tomerr-ma
Copy link
Author

@liyasthomas @AndrewBastin the bug seems to be triggered when Chrome version update occurs.

Seems like chrome.runtime.onInstalled.addListener(() in src/index.js, Line:358 is using this function which according to the docs is "Fired when the extension is first installed, when the extension is updated to a new version, and when Chrome is updated to a new version."

Looks likes the origin list is being overwritten with default origin list on every Chrome Browser update.

image

@SanskritiHarmukh
Copy link

@liyasthomas @AndrewBastin the bug seems to be triggered when Chrome version update occurs.

Seems like chrome.runtime.onInstalled.addListener(() in src/index.js, Line:358 is using this function which according to the docs is "Fired when the extension is first installed, when the extension is updated to a new version, and when Chrome is updated to a new version."

Looks likes the origin list is being overwritten with default origin list on every Chrome Browser update.

image

Hi @tomerr-ma we'll try to reproduce the issue again and revert back to you. Thanks for the update.

JackAdd91 added a commit to JackAdd91/hoppscotch-extension that referenced this issue Mar 12, 2024
Regarding the following issue: hoppscotch#269

This bug is solved with this fix. Now the onInstalled event will not be triggered after chrome version update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants