New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Focus rings on buttons #174
Comments
Hi, It's already planned in the 1.0 rewrite. |
For the input focus style you can use the |
Great to hear that, thanks! |
Is there any way to opt-out of the |
No its not possible, hover styles of button are "hard coded" in the |
That's very unfortunate.
Please note that using _hover or css to override it is not a solution. The
problem is that the hover state sticks, so even if I override it to have
the same background as the non hover state my override will also stick
which is the same problem as the original because it shadows the "active"
state that I want to use to denote a user tap/click.
Maybe if I use both active + hover I can make it work.
…On Sun, Jul 10, 2022 at 10:40 PM Fabien MARIE-LOUISE < ***@***.***> wrote:
No its not possible, hover styles of button are "hard coded" in the
button.styles.ts. The only solution is to override the styles with _hover
or css prop.
—
Reply to this email directly, view it on GitHub
<#174 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARKJWMAYTTXRWDPPRREKODVTMYMDANCNFSM5ZFEWHJQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
---
https://danielorodriguez.com
|
Yeah i understand, you've reach the point of "that's too cumbersome to customize to fit my need" 😅. The library is not that customizable. |
Update, in 1.0 the focus behavior is the same as in Mantine. |
Is your feature request related to a problem? Please describe.
I really like Hope UI, it seems like the best UI library for Solid atm.
However, I personally dislike the focus rings on buttons, I prefer the way Mantine handles it as an example.
Describe the solution you'd like
It would be great if focus rings on buttons were to be removed.
In Mantine, focus rings only show when navigating with the keyboard, which is much cleaner in my opinion.
Describe alternatives you've considered
Additional Notes
One more (less important) thing... Is there a way to change the style of focus rings on text input components?
Looking forward to your response
The text was updated successfully, but these errors were encountered: