Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code path causes memory leak #1

Open
daniel214 opened this issue May 28, 2020 · 0 comments
Open

Code path causes memory leak #1

daniel214 opened this issue May 28, 2020 · 0 comments
Assignees
@daniel214

Comments

@daniel214
Copy link
Collaborator

Input validation errors in pyMsplinkOpen have a code path that does not call free(mspDevice.devname).

python-msptools/msplink/msplink.c

Line 260 in e9255b6

goto release_mutex_handler;

Proposed solution: Move the mspversion and read_retries validation before malloc().
@daniel214 daniel214 self-assigned this May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel214 daniel214

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@daniel214