fix redgif host video and images #5481
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't have much js or extension development experience, I tried to stick to the general structure of the code as much as I could, tell me if I did anything wrong... The python developer inside me could have surfaced here and there and mixed conventions between the languages.
I couldn't make a request to redgif API without the permissions (CORS error) so based on project documentations I added it to "manifest.json", although the documentation gave "api.twitter.com" as an example which doesnt really appear in the manifest anymore, I think the documentations might need a little update.
Relevant issue: fixes #5468
Tested in browser: Firefox, Chrome, Vivaldi