Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ongoing: reactive refactoring #271

Open
climategadgets opened this issue Aug 19, 2023 · 0 comments
Open

Ongoing: reactive refactoring #271

climategadgets opened this issue Aug 19, 2023 · 0 comments
Labels
fault tolerance legacy maintenance reactive Pertinent to Reactive branches only STICKY Issues with this label will not be closed so they are visible at all times

Comments

@climategadgets
Copy link
Member

climategadgets commented Aug 19, 2023 •
edited

The bulk of the reactive conversion is done. However, since there was some "learning on the job", early conversions are subpar, clumsy, and/or outright ugly.

Random updates to pieces having been found especially ugly will be filed under this issue.

Pictured: the reflection on how any code base looks when it has been created during active learning process.
image
@climategadgets climategadgets added STICKY Issues with this label will not be closed so they are visible at all times legacy fault tolerance maintenance reactive Pertinent to Reactive branches only labels Aug 19, 2023
climategadgets added a commit that referenced this issue Aug 19, 2023
@climategadgets
Minor refactoring (#271)
035b760
climategadgets added a commit that referenced this issue Aug 19, 2023
@climategadgets
Provided a workaround for not-quite-reactive HvacDevice (#268, #271)
bebe4ec
@climategadgets climategadgets mentioned this issue Aug 20, 2023
Closed
climategadgets added a commit that referenced this issue Sep 6, 2023
@climategadgets
Added test case identifying problems with HeatPump over MQTT switch (#…
c352712 
…271)
climategadgets added a commit that referenced this issue Sep 6, 2023
@climategadgets
HeatPump reactive overhaul, *almost* passes all tests (#271)
637c71f
climategadgets added a commit that referenced this issue Sep 6, 2023
@climategadgets
HeatPump reactive overhaul, now passes tests but what else is broken? (…
966ff60 
…#271)
climategadgets added a commit that referenced this issue Sep 7, 2023
@climategadgets
Rearranging chairs, dangerously (#271)
32c24bb
climategadgets added a commit that referenced this issue Sep 7, 2023
@climategadgets
Brown bag fix (#271)
7fd7f06
climategadgets added a commit that referenced this issue Sep 7, 2023
@climategadgets
Rearranging more chairs (#271)
2e6adb2
climategadgets added a commit that referenced this issue Sep 7, 2023
@climategadgets
Minor non-destructive refactoring (#271, #279)
e8f700c
climategadgets added a commit that referenced this issue Sep 8, 2023
@climategadgets
Merge branch 'gh271-heatpump' into gh47 (#271)
5661b57
This was referenced Sep 8, 2023
Closed
Closed
climategadgets added a commit that referenced this issue Sep 10, 2023
@climategadgets
Bugfix: observing the schedule without the console as well (#271, #281)
b25988a
climategadgets added a commit that referenced this issue Sep 12, 2023
@climategadgets
Eliminated blocking call in SwitchableHvacDevice (#271)
f51da16
climategadgets added a commit that referenced this issue Sep 12, 2023
@climategadgets
Followup: improved diagnostics in SwitchableHvacDevice (#271)
196a732
climategadgets added a commit that referenced this issue Sep 14, 2023
@climategadgets
Refactored copypaste into a method call (#47, #271)
10872d9
climategadgets added a commit that referenced this issue Sep 15, 2023
@climategadgets
Put ban daids around the thermostat so it doesn't blow up the pipeline (
fd3ebf0 
#271)

Half assed measure, refactoring is coming
climategadgets added a commit that referenced this issue Sep 16, 2023
@climategadgets
Oops... forgot to log the exception (#271)
43d73d0
climategadgets added a commit that referenced this issue Sep 20, 2023
@climategadgets
Split Zone.setSettings() into sync and reactive (#255, #271)
fef5058
climategadgets added a commit that referenced this issue Sep 22, 2023
@climategadgets
Minor refactoring - removed redundant indirections (#271)
0ed8d41
climategadgets added a commit that referenced this issue Sep 22, 2023
@climategadgets
ZonePanel is now processing key presses in a reactive way (#271)
11a4bb3
climategadgets added a commit that referenced this issue Sep 22, 2023
@climategadgets
Minor refactoring - removed redundant indirections (#271)
161f684
climategadgets added a commit that referenced this issue Sep 22, 2023
@climategadgets
Replaced field injections with constructor injections (#271)
70f4be7
climategadgets added a commit that referenced this issue Sep 22, 2023
@climategadgets
Improved console reaction to keypresses (not all the way yet) (#204, #…
5826ec2 
…271)
climategadgets added a commit that referenced this issue Sep 23, 2023
@climategadgets
Collector/connector reactive pipeline minor refactoring (#271)
0f95ce5
climategadgets added a commit that referenced this issue Sep 23, 2023
@climategadgets
Bugfix: now running ONE HTTP connector pipeline (#271)
40f8c87
@climategadgets climategadgets mentioned this issue Sep 25, 2023
Closed
climategadgets added a commit that referenced this issue Oct 4, 2023
@climategadgets
1/2: improved feedback from control inputs to console (#271)
363625f 
2/2: improved feedback from connectors coming in next commit[s]

Note: chances of stalling on start (noticed in rev.
cb446b6) increased, need to fix this for
good soon
climategadgets added a commit that referenced this issue Oct 4, 2023
@climategadgets
2/2: improved feedback loop from HA connector (#271)
c7fb203
climategadgets added a commit that referenced this issue Oct 6, 2023
@climategadgets
Dropped log level on non-essential messages (#271)
3362029
climategadgets added a commit that referenced this issue Oct 6, 2023
@climategadgets
Raised log level on an essential message (#271)
517c1d7
climategadgets added a commit that referenced this issue Oct 6, 2023
@climategadgets
Dropped log level on non-essential messages (#271)
0d889ff
climategadgets added a commit that referenced this issue Oct 6, 2023
@climategadgets
Dropped log level on non-essential messages (#271)
7534b50
climategadgets added a commit that referenced this issue Oct 7, 2023
@climategadgets
Bugfix for race condition from rev. 066185a (how permanent?) (#47, #271)
564a926
climategadgets added a commit that referenced this issue Oct 7, 2023
@climategadgets
Bugfix for race condition from rev. 066185a (how permanent?) (#47, #271)
5cdb82c
climategadgets added a commit that referenced this issue Oct 8, 2023
@climategadgets
Reversed the "no repeat decision", let them keep kicking us in the fa…
d74dade 
…ce (#271)
climategadgets added a commit that referenced this issue Oct 8, 2023
@climategadgets
Removed questionable subscribeOn() (#271, #290)
883bd0c
climategadgets added a commit that referenced this issue Oct 8, 2023
@climategadgets
Eliminated anonymous data structures to improve readability (#271)
13cc043
climategadgets added a commit that referenced this issue Oct 8, 2023
@climategadgets
Improved diagnostics on TimeoutGuard (#271, #290)
fa42488
climategadgets added a commit that referenced this issue Oct 8, 2023
@climategadgets
Assuring non-null ID on TimeoutGuard (#271, #290)
7983d71
climategadgets added a commit that referenced this issue Oct 8, 2023
@climategadgets
Added diagnostics to TimeoutGuard (#271, #290)
7e03c30
climategadgets added a commit that referenced this issue Oct 9, 2023
@climategadgets
Added more diagnostics (#271, #290)
1bb1757
climategadgets added a commit that referenced this issue Oct 9, 2023
@climategadgets
Identified race condition, not necessarily related to #290 (#271)
e08b5f4
climategadgets added a commit that referenced this issue Oct 9, 2023
@climategadgets
More diagnostics (#271, #290)
9bc34aa
climategadgets added a commit that referenced this issue Oct 11, 2023
@climategadgets
Bugfix that broke everything (details below) (#238, #271, #290)
fc34be5 
Original problem: feedback wasn't engaged when economizer wasn't configured
due to a typo

Collateral and deal breaker: fixing the bug makes test cases stall, though
the application somehow keeps working.

This very likely pinpoints the root cause of #290.
climategadgets added a commit that referenced this issue Oct 11, 2023
@climategadgets
Bugfix, complication (details below) (#238, #271, #290)
315d554 
Original problem: feedback wasn't engaged when economizer wasn't configured
due to a typo

Collateral: feedbackFlux is not closed, this is why test cases stall.  Fix
is in the next commit.
climategadgets added a commit that referenced this issue Oct 11, 2023
@climategadgets
Bugfix complication removed (fixed test cases) (#238, #271, #290)
71a8438
climategadgets added a commit that referenced this issue Oct 11, 2023
@climategadgets
Evaluated and adjusted test case; documentation update (#271)
444145b
climategadgets added a commit that referenced this issue Oct 12, 2023
@climategadgets
Moved bugfix (rev. 71a8438) into a better place (#238, #271, #290)
e4d4798
climategadgets added a commit that referenced this issue Oct 18, 2023
@climategadgets
Removed obsolete blocking call (#271, #292)
d6a715e
climategadgets added a commit that referenced this issue Nov 9, 2023
@climategadgets
AbsoluteIncrementAdapter: removed unnecessary 'synchronized' (#271)
559addb
climategadgets added a commit that referenced this issue Nov 9, 2023
@climategadgets
Added diagnostics (#271)
78aef73
climategadgets added a commit that referenced this issue Nov 9, 2023
@climategadgets
Looks like 'synchronized' here is doing more harm than good (#271)
370a441
climategadgets added a commit that referenced this issue Nov 19, 2023
@climategadgets
Hack to diagnose thread starvation (#271)
ec338ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fault tolerance legacy maintenance reactive Pertinent to Reactive branches only STICKY Issues with this label will not be closed so they are visible at all times
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@climategadgets