Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hostname seems not to be in holod configuration #20

Open
frederic-loui opened this issue Apr 17, 2024 · 1 comment
Open

hostname seems not to be in holod configuration #20

frederic-loui opened this issue Apr 17, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@frederic-loui
Copy link
Member

When using remote holi-cli on several nodes, the hostname is always set to holo.

  • Changing the hostname has no effect.
❯ target/debug/holo-cli --address http://clab-ripv2-freertr-rt6:50051
holo#
holo#
holo# configure
holo(config)# hostname R6
R6(config)# commit
% configuration committed successfully
R6(config)# exit
R6# exit
  • exit and log again
holo# exit
❯ target/debug/holo-cli --address http://clab-ripv2-freertr-rt6:50051
holo#
holo#
holo#
  • Issuing show running also show no hostname:
❯ target/debug/holo-cli --address http://clab-ripv2-freertr-rt6:50051
holo# show running
!
interfaces interface lo
 type iana-if-type:ethernetCsmacd
 ipv4
!
interfaces interface eth1
 type iana-if-type:ethernetCsmacd
 ipv4
!
interfaces interface eth2
 type iana-if-type:ethernetCsmacd
 ipv4
!
routing control-plane-protocols control-plane-protocol ietf-rip:ripv2 main
 !
 rip interfaces interface lo
 !
 rip interfaces interface eth1
 !
 rip interfaces interface eth2
!
@frederic-loui frederic-loui changed the title hostname seems to to be in holod configuration hostname seems not to be in holod configuration Apr 17, 2024
@frederic-loui frederic-loui changed the title hostname seems not to be in holod configuration hostname seems not to be in holod configuration Apr 17, 2024
@rwestphal
Copy link
Member

I agree. The current "hostname" command feels more like a gimmick than anything useful.

I believe the best course of action is to implement the 'ietf-system' module, which would provide us with the 'system hostname STRING' command. Then, the CLI should use the hostname from the running configuration in the prompt.

@rwestphal rwestphal added the enhancement New feature or request label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants