Skip to content

Latest commit

 

History

History
38 lines (29 loc) · 3.17 KB

CONTRIBUTING.md

File metadata and controls

38 lines (29 loc) · 3.17 KB
Raw

Contributing to HollaEx Kit

We love your input! We want to make contributing to this project as easy and transparent as possible, whether it's:

  • Reporting a bug
  • Discussing the current state of the code
  • Submitting a fix
  • Proposing new features
  • Becoming a contributor

How to submit an issue

We use GitHub issues to track public bugs. Report a bug by opening a new issue; it's that easy! Before you do so check forum and see if you find the answer to your issues or questions. Also keep your issues in GitHub to only tech related topics. For not tech related matters you can contact support@hollaex.com.

How to Contribute Code

Before you contribite any code we assume that you have read the license and accept to give the full right of your code to HollaEx for its public use. To submit a code contribution, make sure you open a Pull Request to develop branch describing the code change clearly in english and provide any additional information in your PR. Follow the code format used in the project and run prettier as well as eslint configuration set in the project.

Language Support

Language strings are stored in web as well as emails. To add a new language you need to create a new language file in both web and mail following ISO 639-1 standard.

web

You can start by copying en.js file and rename en to the new ISO 639-1 language and start translating. Some notes to remember when doing the translation:

  • Do not change the file keys. For example in APP_TITLE: 'HollaEx'. APP_TITLE should not be changed since it is used as an identifier.
  • Keep the JavaScript object format and do not change string quotes such as '', commas , etc.
  • Do not remove numbers in brackets such as {0} or {1} etc. These are dynamic values such as the coin name etc and should not be changed. You need to just rearrange the placement of such words in the sentence if necessary.
  • Everything should be JSON format and in case you find an object such as the example below, you need to only translate the object values and not the keys.
"TYPES": { "MARKET": "market", "LIMIT": "limit" }
"TYPES": { "MARKET": "سوق", "LIMIT": "حد" },

In this case as you can see, only the values of market and limit are translated.

mail

Just like web strings the are emails that should be supported for each new language. Start by copying this english translation file similar to the web and add all the new email translations into this json file. Please keep in mind not to change dynamic variables inside ${} such as ${email} and html tags such as <p> or </p>.

Discussion

We use GitHub strictly to code and do not use it for general discussions. For general discussions with others in the community and sharing your ideas, feature request you can use Discord and make sure to check Forum posts for any questions you have.