Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic testing #91

Open
holgerteichgraeber opened this issue Jun 25, 2019 · 4 comments
Open

Automatic testing #91

holgerteichgraeber opened this issue Jun 25, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@holgerteichgraeber
Copy link
Owner

Implement automatic testing for clustering methods and extreme value selection.

@holgerteichgraeber
Copy link
Owner Author

I am thinking about the following case and was wondering if you have run into something similar with CapacityExpansion automatic testing, @YoungFaithful ?

When we do run_clust with kmeans or kmedoids, it will always initialize randomly. there is always a chance that even with large number of initializations, we do not get the same clusters in the end.

Do you use kmeans or kmedoids as a base step for CapacityExpansion testing, or only hierarchical?

@holgerteichgraeber holgerteichgraeber added the enhancement New feature or request label Jun 25, 2019
@holgerteichgraeber
Copy link
Owner Author

note for future: Potentially use https://github.com/JuliaPlots/VisualRegressionTests.jl

@holgerteichgraeber
Copy link
Owner Author

holgerteichgraeber commented Jul 1, 2019

Let's name the test files in the test folder similar to the files in the src folder.

I am keeping a running list of tests that still need to be implemented. If possible, these tests should be without loading any data (see for example tests in utils.jl), but rather test the functionality based on simple examples.

  • entire intraperiod segmentation file
  • load_data.jl : combine_timeseries_weather_data()
  • utils.jl : run_pure_clust() - here, let's also think if there is a more descriptive name
  • optim_problems.jl (Holger)

@holgerteichgraeber
Copy link
Owner Author

holgerteichgraeber commented Jul 1, 2019

@YoungFaithful: What was the issue in CapacityExpansion with the number of significant digits of the input data? Where did it show up, was it a small error in the optimization when you were running your tests, or something more significant?
Somehow kmeans + centroid does not perform reliably, if we use the ] test ClustForOpt, it fails, and I guess it is because of some rounding/ machine error, or alternatively due to random initializations.

holgerteichgraeber added a commit that referenced this issue Jul 3, 2019
Testing + code coverage
- Addresses #91 
- connection to codecov.io : https://codecov.io/gh/holgerteichgraeber/ClustForOpt.jl .
- cleanup of some unused functions
- replaced `@error` by `error(msg)`. The former is used for logging, whereas the later throws an Exception. We want the latter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants