Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hotlink the GitHub avatars #199

Open
ivan-aksamentov opened this issue Jul 15, 2021 · 0 comments
Open

Don't hotlink the GitHub avatars #199

ivan-aksamentov opened this issue Jul 15, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ivan-aksamentov
Copy link
Member

This is about the contributors portraits in the footer.

Currently we take image URls which all-contributors provide (generated automatically):
https://github.com/hodcroftlab/covariants/blob/master/.all-contributorsrc

The URLs are used here:

<Portrait src={contributor.avatar_url} />

We might either download the images as a build step and then serve them ourselves, or to use something like Next.js image component which will handle this automatically (if I remember correctly).

@ivan-aksamentov ivan-aksamentov added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers needs triage Pending maintainers' attention and removed needs triage Pending maintainers' attention labels Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant