Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX/Bug] Keyboard layout (language) unexpectedly changes #709

Open
Toliak opened this issue Apr 13, 2021 · 4 comments · May be fixed by #712
Open

[UX/Bug] Keyboard layout (language) unexpectedly changes #709

Toliak opened this issue Apr 13, 2021 · 4 comments · May be fixed by #712

Comments

@Toliak
Copy link

Toliak commented Apr 13, 2021

Description
I'm frustrated when I open a circuit element properties window, change keyboard layout and, when I close the window, it unexpectedly changes back...

How to reproduce
0. Setup multiple language layouts in the OS

  1. Create empty circuit, insert any element
  2. Open the element properties (RMB)
  3. Change keyboard layout
  4. Close the properties window
  5. Expected: no layout change. Got: layout change

Screenshots
Step 1:
image

Step 2,3:
image

Step 4,5:
image
@hneemann
Copy link
Owner

I have no idea what is happening, and there is no code in the simulator itself that does this.
I would be surprised if it was even possible in java to change the language of the user interface.
What operating system are you using and does this happen with other Java applications as well?

@Toliak
Copy link
Author

Toliak commented Apr 13, 2021

Windows 10 1909
Java version:

java version "1.8.0_192"
Java(TM) SE Runtime Environment (build 1.8.0_192-b12)
Java HotSpot(TM) 64-Bit Server VM (build 25.192-b12, mixed mode)

I think I don't use other Java apps (except for PyCharm, but it has embedded Java version)

I will check this bug in Manjaro Linux later...

@hneemann
Copy link
Owner

Your Java version is quite old.
You should possibly use a more recent version.
AdoptOpenJDK is a easy to install option.

@Toliak
Copy link
Author

Toliak commented Apr 13, 2021 •
edited

Oracle JDK 15: the same issue
image

Manjaro Linux, openjdk 15: no issues (but I use Digital on Windows usually)

AdoptOpenJDK 11: unfortunately, the same issue
image

I will try to debug the latest code, maybe will catch something...

UPD 1: Closing a properties window does not trigger language change. Focusing main circuit window triggers.

UPD 2: https://stackoverflow.com/questions/9667947/preserving-keyboard-layout-in-swing-app

@Toliak Toliak linked a pull request Apr 13, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unexpected keyboard layout changes
2 participants
@hneemann @Toliak