-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Ob-async does not work. #2010
Comments
We have this hack in place to prevent this issue. I cannot reproduce it. Please include your |
Also, ob-async is already installed by Doom. You do not need to install or configure it yourself. |
I knew, Ob-async included in org feature. I just added (use-package! ob-async) in my config file. if you do not configure this. the ob async does not work. |
|
that will help you easy test : Org-src: #+RESULTS: make sure results has output async task ID |
Ah, I can reproduce it. Try this and see if it resolves the issue: (add-hook! 'ob-async-pre-execute-src-block-hook
(load (expand-file-name "init.el" user-emacs-directory))) |
thanks, it's solved the issue. but if the user place initialization logic in ob-async-pre-execute-src-block-hook, which runs before execution of every src block. such as Julia: added your config
new issue. |
How about: (defadvice! +org-init-doom-during-async-executation-a (orig-fn &rest args)
:around #'ob-async-org-babel-execute-src-block
(let ((ob-async-pre-execute-src-block-hook
(cons (lambda () (load (expand-file-name "init.el" user-emacs-directory)))
ob-async-pre-execute-src-block-hook)))
(apply orig-fn args))) This should ensure that our hook is always first. |
debug info :
Debugger entered--Lisp error: (file-missing "Cannot open load file" "No such file or directory" "org")
signal(file-missing ("Cannot open load file" "No such file or directory" "org"))
async-handle-result((lambda (result) (with-current-buffer # (let ((default-directory "/home/gtrun/project/my-code/my-julia/")) (save-excursion (cond ((member "none" ...) (message "result silenced")) ((member "silent" ...) (message ...)) (t (goto-char #) (let ... ... ... ...))) (run-hooks (quote org-babel-after-execute-hook)))))) (async-signal (file-missing "Cannot open load file" "No such file or directory" "org")) #)
async-when-done(# "finished\n")
|
Those errors don't seem related, but try this: (defadvice! +org-init-doom-during-async-executation-a (orig-fn &rest args)
:around #'ob-async-org-babel-execute-src-block
(let ((ob-async-pre-execute-src-block-hook
;; Ensure our hook is always first
(cons `(lambda ()
(load ,doom-autoload-file)
(load ,doom-package-autoload-file))
ob-async-pre-execute-src-block-hook)))
(apply orig-fn args))) |
|
I cannot reproduce these new errors, but try this: (defadvice! +org-init-doom-during-async-executation-a (orig-fn &rest args)
:around #'ob-async-org-babel-execute-src-block
(let ((ob-async-pre-execute-src-block-hook
;; Ensure our hook is always first
(cons `(lambda ()
(load ,(expand-file-name "init.el" doom-emacs-dir)))
ob-async-pre-execute-src-block-hook)))
(apply orig-fn args))) |
If possible, can you hop on our discord? I don't want to spam here. |
This allows batch scripts to load $EMACSDIR/init.el to use Doom's API. Howevever, it puts the onus on the user to run `doom refresh` before trying to use it. This also indirectly addresses #2010
Is this issue solved? I have the latest version of doom as 11/19/2019 20:30 PDT. But I still have missing |
|
I can no longer reproduce the issue. @ztlevi Try
Don't do this. It is unnecessary and loads all of org. ob-async will be automatically loaded if your src block has a non-nil |
I still get the error.
I am using org-wild-notifier. Can you please try this package and enable it
|
Ran without issue. Ran it multiple times, even. Currently on 24efd5b with Emacs 26.3. |
Side-note: |
What about you trigger it manually? Did you get the error? |
this issue not about org-babel-async. I tried to download the org-wild-notifier. also got the same error report. |
Agh. I see it. It's the way org-wild-notifier scrapes your org agenda files. It uses async much like ob-async does, except unlike ob-async, it doesn't provide us a way to inject Doom's state before it runs. This is non-trivial to fix from Doom's side. I suggest using org-alert instead (or org-notify, included with org-plus-contrib). |
Emm, org-alert doesn't really work. While Is this possible to fix it from |
We generate an org-version.el file, rendering our old org-release hacks unnecessary. This may cause breakages for uses who do deep clones of org-plus-contrib; needs testing.
As of 30f72da I've employed a new solution to this and the ob-async problem, which should resolve your issue with org-wild-notifier-mode. Let me know if that isn't the case. (You'll need to |
Nice! It works! 💯 |
the bug output
error in process sentinel: Cannot open load file: No such file or directory, org-version.el
see issues
if you clean up
rm -rf ~/.emacs.d/.local/straight/build/org-plus-contrib/*.elc
. it's working.But, we got new problem, the emacs can not find org version. similar like this issues.
The text was updated successfully, but these errors were encountered: