-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hat_reaction changing kmc type not intuitive #385
Comments
If I'm not mistaken, it is not 'changed' by the plugin, it is set in the first place by the plugin. If the user wants, he can overwrite the choice in the kimmdy.yml, either in the root of it or per plugin. So, if you set the algorithm in the root of the config, this also should be used. If this choice is not honored, I'd consider it a bug |
Effectively the plugin changes the behavior of the kimmdy run because decide_recipe is outside of the plugin. For Eddie this was unexpected behavior and I agree. The same applies for apply_recipe but I think this is closer related to the plugin than decide_recipe. |
Write whole config object to json in 0_setup? |
make plugin documentation accessible thorugh kimmdy documentation? |
From a user perspective it is confusing that the kmc type is changed by a reaction plugin. I think it should be a setting in the kimmdy config.yml, not of the individual plugins.
(written by Eric)
Any thought on this?
The text was updated successfully, but these errors were encountered: