Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterization plugins don't know their task directory #337

Open
ehhartmann opened this issue Nov 16, 2023 · 3 comments
Open

Parameterization plugins don't know their task directory #337

ehhartmann opened this issue Nov 16, 2023 · 3 comments

Comments

@ehhartmann
Copy link
Collaborator

Grappa is writing some files but writes to the current directory. For this to be changed to the correct task directory, a parameterization plugin would need to know the task directory.

@jmbuhr
Copy link
Collaborator

jmbuhr commented Nov 16, 2023

can you make parameterization as Task such that this can be handled via TaskFiles?

@ehhartmann
Copy link
Collaborator Author

I think that would be a little awkward because the parameter update called in quite a few different cases (eg converting a Topology to a TopologyDict).
One could just write the grappa plugin input/output information to the logfile for now.

@jmbuhr
Copy link
Collaborator

jmbuhr commented Nov 24, 2023

but isn't this part of an apply-recipe task? Handling file IO and working directories is part of the reason we came up with the Task model, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants