Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple koin modules #9

Open
annshsingh opened this issue Dec 30, 2019 · 4 comments
Open

Multiple koin modules #9

annshsingh opened this issue Dec 30, 2019 · 4 comments

Comments

@annshsingh
Copy link
Contributor

I think it would be best if we create multiple Koin modules instead of one.
What I mean to say is that there can be modules like:

  1. NetworkModule
  2. DatabaseModule
  3. ViewModelModule
  4. RepositoryModule etc
@hitanshu-dhawan
Copy link
Owner

Yes, I have made multiple Koin modules on the movies branch. Like this.

@annshsingh
Copy link
Contributor Author

@hitanshu-dhawan Looks good, we can have seperate files for every module.

@hitanshu-dhawan
Copy link
Owner

I prefer to separate the modules depending on the environment.

For example,

  • KoinModules.kt will have all the normal modules.
  • TestKoinModules.kt will have all the testing modules.

@annshsingh
Copy link
Contributor Author

@hitanshu-dhawan That'll work for small projects. I see that this project will have a lot of elements down the line, I believe having multiple files will increase readability and reduce confusion.
I'll try and segregate modules once after you add paging and then you can have a look, see if it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants