Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indicate that SQLSelectTableJoinConditions.Add(string, ComparisonOperator, string) is obsolete #20

Closed
hisystems opened this issue Mar 4, 2012 · 0 comments
Closed

Indicate that SQLSelectTableJoinConditions.Add(string, ComparisonOperator, string) is obsolete #20

hisystems opened this issue Mar 4, 2012 · 0 comments
Assignees
@hisystems
Labels
Maintenance
Milestone
Release 3.7.0.0

Comments

@hisystems
Copy link
Owner

This function is only required for backward compatibility. All new functionality should utilise the new overloaded Add() function.
@ghost ghost assigned hisystems Mar 4, 2012
hisystems added a commit that referenced this issue Mar 4, 2012
@hisystems
Added support for conditions precedence in table join conditions. Closes
6c6eac6 
 #18.

SQLSelectTableJoinConditions objects can now be created and a collection of conditions can be added to an SQLSelectTableJoinConditions object to group a set of conditions and to ensure the sub-conditions are wrapped in parentheses and executed logically first as per the mathematical order of operations.

Removed the reference to the Friend SQLSelectTableJoinConditions.Parent property because this is not utilised by the library.

SQLSelectTableJoinConditions.Add(String, ComparisonOperator, String) is only accessible if used when the parent SQLSelectTableJoin is used and it remains only for backward compatibility reasons. Created issue #20 to indicate that this method should be marked as obsolete.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hisystems hisystems

Labels
Maintenance
Projects
None yet
Milestone
Release 3.7.0.0
Development

No branches or pull requests
1 participant
@hisystems