Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I2C GPS #46

Open
Ptosiek opened this issue Oct 12, 2023 · 2 comments
Open

I2C GPS #46

Ptosiek opened this issue Oct 12, 2023 · 2 comments

Comments

@Ptosiek
Copy link
Contributor

Ptosiek commented Oct 12, 2023

I know you wrote the support as 'experimental' but:
I've just got the Pimoroni breakout module and connected it though I2C (just because it's easier, and also wanted to test that code path)
The pa1010d lib does not return the track, and the "timestamp" field returned is a time object not a datetime.

But it's a lib limitation (cf. https://github.com/pimoroni/pa1010d-python/pull/12/files)

Should we:
1 Fork the lib
2 Reimplement it in this repo
3 Drop direct I2C support and somewhat pass it through GPSD anyway (cf https://ozzmaker.com/accessing-gps-via-i2c-on-a-berrygps-imu/), that suppose a bugger rewrite (mainly the way we detect/use the GPS sensor)

It's somewhat blocking this branch:
https://github.com/Ptosiek/pizero_bikecomputer/tree/gps
unless we decide to solve that later.
(The adafruit uart path is not tested either)

@hishizuka
Copy link
Owner

Hi @Ptosiek ,
thank you for researching pa1010d-python Library.
Let's stop supporting I2C and adafruit UART.
I thought I2C connected GPS would be a bit more popular at the time. In the end, GPSd is good enough.

@Ptosiek
Copy link
Contributor Author

Ptosiek commented Oct 13, 2023

Could not make it work (i2c=> gpsd) just yet (will keep trying). I will prob just open the gps PR as is so you can have a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants