Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF generation won't output all pages when there is fragments #488

Open
1 of 2 tasks
terra-yi opened this issue Apr 7, 2021 · 1 comment
Open
1 of 2 tasks

PDF generation won't output all pages when there is fragments #488

terra-yi opened this issue Apr 7, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@terra-yi
Copy link

terra-yi commented Apr 7, 2021

Info

  • Operating System: Windows 10
  • Node Version: 12.18.3
  • Browser Name and Version: Chrome 89

Type

  • bug
  • feature request

Expected Behavior

For example when there are total 8 pages and one page has 3 fragments, it should generate total 11 pages.

Actual Behavior

It discards last 3 pages and generates only 8 pages.

How can we reproduce the behavior?

create a presentation with fragments and try to generate pdf

Problematic code

@fusuma/task-pdf/src/index.js has following code to guess the number of total slides which does not count fragments.

const totalSlidesNum = await page.evaluate(
    () => Array.from(document.querySelectorAll('.swiper-slide')).length
  );
@hiroppy hiroppy added the bug Something isn't working label Apr 10, 2021
@hiroppy
Copy link
Owner

hiroppy commented Apr 10, 2021

thank you for reporting. I'll fix this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants