Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

share.Glob does not return error #87

Open
palevi67 opened this issue Nov 25, 2023 · 0 comments
Open

share.Glob does not return error #87

palevi67 opened this issue Nov 25, 2023 · 0 comments

Comments

@palevi67
Copy link

palevi67 commented Nov 25, 2023

... in case of missing permissions or other I/O errors. As per filepath.go, this seems to be intentional:

func (fs *Share) glob(dir, pattern string, matches []string) (m []string, e error) {
	m = matches
	fi, err := fs.Stat(dir)
	if err != nil {
		return // ignore I/O error
	}

but, why? This difficults the detection of SMB configuration problems.

Best regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant