Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The relprop method of the Linear layer #64

Open
Hongbo-Z opened this issue Dec 30, 2023 · 1 comment
Open

The relprop method of the Linear layer #64

Hongbo-Z opened this issue Dec 30, 2023 · 1 comment

Comments

@Hongbo-Z
Copy link

HI Chefer,

Is there a typo with Lines 218 to 219

S1 = safe_divide(R, Z1 + Z2)
S2 = safe_divide(R, Z1 + Z2)

which should be the below?
S1 = safe_divide(R, Z1)
S2 = safe_divide(R, Z2)
according to https://github.com/wjNam/Relative_Attributing_Propagation/blob/7fa96822740591b605712f251e556ec8487d1eea/modules/layers.py#L268-L269C36

Thanks,

Hongbo

@michaelkiper
Copy link

I want to follow this issue as well. It's something I noticed as well. Curious why you add by both the Z1 and Z2 terms to project the Relevance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants