Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helpful methods to entities #400

Open
davfsa opened this issue Dec 19, 2020 · 4 comments
Open

Add helpful methods to entities #400

davfsa opened this issue Dec 19, 2020 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers medium Medium size tasks that may require changing/implementing/fixing/removing several things
Projects
v2.0.0
Milestone
2.0.0

Comments

@davfsa
Copy link
Member

davfsa commented Dec 19, 2020 •
edited

All the objects under the root project (ie, channels.py, guilds.py, and similar) should maybe provide helpful methods to call either app.cache or app.rest while filling in the known arguments.

Going down this path might lead to "wrong" coding practices like guild.get_channel().send_message(). We should consider a nicer approach to this or remove "helpful methods" entirely.
@davfsa davfsa added enhancement New feature or request good first issue Good for newcomers medium Medium size tasks that may require changing/implementing/fixing/removing several things labels Dec 19, 2020
@davfsa davfsa added this to the 2.0.0 milestone Dec 19, 2020
@davfsa davfsa added this to To do in v2.0.0 via automation Dec 19, 2020
@davfsa davfsa mentioned this issue Dec 19, 2020
Merged
2 tasks
@Jonxslays Jonxslays mentioned this issue Aug 28, 2021
Merged
2 tasks
Jonxslays added a commit to Jonxslays/hikari that referenced this issue Aug 30, 2021
@Jonxslays
Add sticker methods to PartialGuild (hikari-py#400)
cab08c4 
 - fetch_sticker
 - fetch_stickers
 - create_sticker
 - edit_sticker
 - delete_sticker

Clarify hikari.api.rest docstrings
davfsa pushed a commit that referenced this issue Aug 30, 2021
@Jonxslays
Add sticker methods to PartialGuild (#400) (#754)
c106689 
- fetch_sticker
 - fetch_stickers
 - create_sticker
 - edit_sticker
 - delete_sticker

Clarify hikari.api.rest docstrings
@ddjerqq
Copy link

ddjerqq commented Feb 1, 2023

can I get more info about this?
I'm interested in contributing to this repo

@davfsa davfsa changed the title Add helpful properties to entities Add helpful methods to entities Feb 1, 2023
@davfsa
Copy link
Member Author

davfsa commented Feb 1, 2023

The description is missing from when the issue was transferred from the old repository I believe. Filled in!

Thank you for showing interest in the project <3

@ddjerqq
Copy link

ddjerqq commented Feb 4, 2023 •
edited

which method do you need implemented?

@davfsa
Copy link
Member Author

davfsa commented Feb 4, 2023

Someone would have to go around and check which ones specifically, as (as far as I am aware), there is no list anywhere. Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers medium Medium size tasks that may require changing/implementing/fixing/removing several things
Projects
v2.0.0
  
To do
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@davfsa @ddjerqq