Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support avro logical type? #323

Open
chenharryhua opened this issue Aug 24, 2020 · 5 comments
Open

support avro logical type? #323

chenharryhua opened this issue Aug 24, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@chenharryhua
Copy link

No description provided.

@dmarticus
Copy link
Contributor

@chenharryhua can you provide more information about what you mean by this issue? Is there a specific use case you have in mind that skeuomorph doesn't cover?

@chenharryhua
Copy link
Author

My bad. I try to use skeuomorph in my project to transform avro schema to/from spark struct-type. my attempt looks like this: https://github.com/chenharryhua/nanjin/blob/master/spark/src/main/scala/com/github/chenharryhua/nanjin/spark/NJDataTypeF.scala . skeuomorph looks like a more general/idiomatic way to do it. but seems there are two missing parts in AvroF, one is how to transform avro logical type to AvroF and another is how to deal with decimal.

@dmarticus
Copy link
Contributor

No problem at all! Thanks for sharing your example; I'll look into this more tomorrow and let you know what I find.

@dmarticus dmarticus added the enhancement New feature or request label Aug 25, 2020
@dmarticus
Copy link
Contributor

Confirmed that your assessment around the missing parts of AvroF is correct. Great catch! We'll triage this issue in our backlog and would happily welcome a PR if you have a good idea for the implementation :)

@chenharryhua
Copy link
Author

Thank you, @dmarticus. I will have a try later. I am uncertain about how to transform AvroF to MuF once the logical type is added and its impact on Probuf schema which I thought also need to transform to MuF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants