Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unary Health Check Service should support not only protobuf but also avro #633

Open
ememmr opened this issue Aug 6, 2019 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@ememmr
Copy link
Contributor

ememmr commented Aug 6, 2019

There's a first version of health check service resolved in issue #626. Right now, unary service uses protobuf protocol, it should also support avro.

Here, the improvement suggestion:

[...]
We could have the following modules:
* `health-check-protocol-unary`: With the current unary `@service`
* `health-check-service-unary`: Depending on `channel` and `health-check-protocol-unary-scala` with the `% provided`

We could also include the `avdl` and `proto` files in the `channel` resources, providing instructions about how to add the sbt settings for generating your protocol definition.
[...]

Originally posted by @fedefernandez in #630 (comment)

@ememmr ememmr added the enhancement New feature or request label Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant