Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GRPC performance benchmarking service #73

Open
arianvp opened this issue Jan 13, 2020 · 4 comments
Open

Implement GRPC performance benchmarking service #73

arianvp opened this issue Jan 13, 2020 · 4 comments
Labels
enhancement New feature or request hacktoberfest help wanted Extra attention is needed rpc

Comments

@arianvp
Copy link

arianvp commented Jan 13, 2020

Official gRPC implementations are benchmarked against a standard benchmarking suite.

https://grpc.io/docs/guides/benchmarking/

https://github.com/grpc/grpc/tree/master/src/proto/grpc/testing

It would be useful to implement this benchmarking suite for mu-haskell as well; to see how well it fares against implementations in other languages and to catch performance regression issues.

@kutyel kutyel added enhancement New feature or request help wanted Extra attention is needed rpc labels Jan 13, 2020
@serras
Copy link
Collaborator

serras commented Jan 13, 2020

mu-haskell in this case is just a thin layer over https://github.com/haskell-grpc-native/http2-grpc-haskell. Maybe we should try to write a benchmarking suite against that at first step?

@arianvp
Copy link
Author

arianvp commented Jan 13, 2020

Given we need to implement specific protobuf services, I thought it would be more ergonomic to put them in mu-haskell as that's where the protobuf generation code lives right?

Also I'm willing to give a shot at this.

@serras
Copy link
Collaborator

serras commented Jan 13, 2020

Feel free to try and send a PR. This will also help us enormously to see if somebody else outside of the maintainer group can work with the given API :)

@arianvp
Copy link
Author

arianvp commented Jan 13, 2020

Exactly my thought :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest help wanted Extra attention is needed rpc
Projects
None yet
Development

No branches or pull requests

3 participants