Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

destroyExport on export module should check if extra button exists first #4553

Closed
jackie-benowitz opened this issue Sep 9, 2015 · 3 comments

Comments

@jackie-benowitz
Copy link

Hi,

I'm currently using the export module to export my charts to png/pdf's external from the chart (by calling chart.exportChartLocal) . I have exporting:false on the chart itself.

When i call chart.destroy() the destroyExport() is eventually called (exporting.js line 715 on v4.1.8). I'm getting the error Cannot read property 'length' of undefined within this method because chart.exportSVGElements does not exist. To workaround, i'm manually setting this to an empty array, however this should probably be handled internally by checking it's existence before calling .length on it.

@TorsteinHonsi
Copy link
Collaborator

Can you help us reproduce that? Here's my try: http://jsfiddle.net/highcharts/x75ft843/

@pawelfus
Copy link
Contributor

I guess this happens when setting exporting: false, while should be exporting: { enabled: false } (misconfigured options), example: http://jsfiddle.net/x75ft843/1/

@jackie-benowitz
Copy link
Author

whoops @pawelfus was right. I think i was reading old documentation on exporting: false because we've had that set for years now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants