Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StockTools | Lot of non proper handled eventListners causing warnings and performance issues #139

Closed
slashvortal opened this issue Jul 5, 2019 · 6 comments

Comments

@slashvortal
Copy link

slashvortal commented Jul 5, 2019

Situation

On Chrome
Lot of noticeable non proper handled eventListners thrown in the console. mainly refers to touchstart event
[Violation] Added non-passive event listener to a scroll-blocking <some> event. Consider marking event handler as 'passive' to make the page more responsive.

On Fireforx and IE11
Low performance on drag and accessing stockTools scroller.

To reproduce

This can be easily noticeable in the console of any react-based demo of StockChart with enabled stock-toos module.
Here is a quick demo: https://codesandbox.io/s/10yv629397

@ppotaczek
Copy link
Contributor

Hi @slashvortal,

I tested your example, but I did not notice any difference in performance or messages in a browser console. This react wrapper should not have any effect on how the stock tools work.

Could you check if that issue is also noticeable in this example, without the wrapper?

Best regards!

@slashvortal
Copy link
Author

Yes I'm able to reproduce it without the wrapper.
I think it is non react-version-related issue as I can reproduce the same here or with any StockTools enabled ones:
https://www.highcharts.com/stock/demo/stock-tools-gui

Mainly on Mac's Chrome lates 2 versions
On windows Edge, you can see it when you try to resize the screen ++
Tested on several machines
Screenshot 2019-07-08 at 16 38 38

@KacperMadej
Copy link

Unable to recreate using Chrome, Edge, Firefox on Windows 10.

@slashvortal
Copy link
Author

Here is a video using MacOS (Mojave) Chrome (Version 75.0.3770.100) - Also tried it with the team on different machines/chromes. Chrome is the only one showing these warnings. Edge is about a performance when resizing but you can ignore it for now till I am able to provide more details on Edge.

https://imgur.com/a/Wba2Aft

@slashvortal
Copy link
Author

slashvortal commented Jul 9, 2019

I will report this in the HighCharts repo since it is not react-version-related issue!

@sebastianbochan
Copy link

Im closing this ticket due to incorrect repo.

New ticket is here: highcharts/highcharts#11353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants