Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The data-graph-color attribute is limited to 9 series #9

Open
agallou opened this issue Dec 19, 2011 · 1 comment
Open

The data-graph-color attribute is limited to 9 series #9

agallou opened this issue Dec 19, 2011 · 1 comment

Comments

@agallou
Copy link
Member

agallou commented Dec 19, 2011

The data-graph-color attribute is limited to 9 series.

      for(var i=0; i<9; i++) {
        var dataname = 'graph-color-' + (i+1);
        colors.push(typeof $table.data(dataname) != 'undefined' ? $table.data(dataname) : typeof themeColors[i] != 'undefined' ? themeColors[i] : defaultColors[i]);
      }

The highchartTable plugin can only set colors for 9 series. It should work with as many series as the chart contains.

@hasokeric
Copy link

could this have been done for performance reasons? But on the other hand js is fast. This will even loop 9x if you have only 1 color specified. So maybe a for should be changed, this being a jquery plugin using sizzle to get graph-color attrs would perhaps be better?

Thoughts anyone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants