Attributes "data-graph-yaxis-X-reversed" are not interpreted by the browser if X is an integer #60
Labels
Comments
agallou
added a commit
to agallou/jquery-highchartTable-plugin
that referenced
this issue
Nov 15, 2015
`data-graph-yaxis-X-*` attributes doesn't work on jQuery 2 (but `data-graph-yaxisX-*` work). `data-graph-yaxis-X-*` works on the master branch of jQuery. In order to have a version that work on all jQury versions we have to support the `data-graph-yaxisX-*` version that will be the new norm. To avoid a Backward compatibility break, we need to support both versions of the attribute. * Now all `data-graph-yaxis` attributes could be written with or without a dash before the axis number. * There is tests on all the attributes, in both versions * tests are executed on both jQuery 2 and jQuery 1 see issue highchartTable#60
|
When #75 will be merged, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
$table.data('graph-yaxis-'+yAxisNum+'-min')is always null on my browser, even if the attribute data-graph-yaxis-1-min is set on the<table>.Looks like this "1" between 2 dashes is the problem.
When I look at
document.querySelector('table').datasetI get :When I look at '$('table').data()` I get :
So jQuery seems to have issues when mapping the dataset to an object.
I suggest using another convention for naming these data-attributes. :)
Browser : Firefox 32.0.3
Jquery : 2.1.1
The text was updated successfully, but these errors were encountered: