Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReactiveStreams and Java 9 Flow API support #53

Closed
hantsy opened this issue Jan 25, 2020 · 7 comments
Closed

ReactiveStreams and Java 9 Flow API support #53

hantsy opened this issue Jan 25, 2020 · 7 comments
Labels
enhancement New feature or request

Comments

@hantsy
Copy link

hantsy commented Jan 25, 2020

Please add ReactiveStreams(rxjava2, reactor, MP ReactiveStreams etc)and Java 9 Flow API support.

it could be designed like the .rx() method of JAXRS client, provide variants to openRxSession(<accept a impl type>).

@hantsy hantsy changed the title ReactiveStream and Java 9 Flow API support ReactiveStreams and Java 9 Flow API support Jan 25, 2020
@gavinking
Copy link
Member

@hantsy we definitely want to supporting other options than just CompletionStage but I'm going to delegate thinking about precisely which ones we support to people like @cescoffier and @FroMage and @emmanuelbernard.

My only suggestion is that I guess we could have multiple RxSession interfaces in different packages, and you could choose which one to unwrap().

(A tangential issue is that we also need to support reactive database drivers other than the ones Vert.x provides.)

@gavinking gavinking added design A design or implementation issue enhancement New feature or request labels Jan 25, 2020
@emmanuelbernard
Copy link
Member

That is something we need to discuss. if we go for Mutiny CC @cescoffier instead of CompletionStage, then Mutiny has bridges tot he other types and is an implementation of ReactiveStreams (for Publisher at least).

@gavinking gavinking removed the design A design or implementation issue label May 21, 2020
@gavinking
Copy link
Member

Note that this is now a very easy thing for a user to contribute.

@cescoffier
Copy link

I agree with @emmanuelbernard :-)

@gavinking
Copy link
Member

@cescoffier I already implemented a Mutiny-based API. It's documented in the readme and in the example program.

@cescoffier
Copy link

Cool! I will have a look!

@gavinking
Copy link
Member

Mutiny ... is an implementation of ReactiveStreams

Alright, so from what I can see here:

https://smallrye.io/smallrye-mutiny/

The Mutiny API does already let people easily use Hibernate Reactive with other reactive streams implementations.

Java 9 Flow API support

I don't know anything at all about this, but it also seems to be ReactiveStreams, so perhaps that's covered too. Anyway, we're targeting Java 8 for good reasons so we can't do anything specific with this API right now.

Look, I'm going to close this issue, since it's simply a bit too open ended.

Once someone has some real concrete use-case-driven experience, they can open new issues to request specific new APIs.

Right now I can't see what code I could possibly write that would let me mark this issue as "done". (Or rather, I probably already wrote the code when I added Mutiny.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants