Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Mutiny 2.5.4 #1841

Closed
wants to merge 1 commit into from
Closed

Upgrade to Mutiny 2.5.4 #1841

wants to merge 1 commit into from

Conversation

jponge
Copy link
Contributor

@jponge jponge commented Jan 19, 2024

No description provided.

@DavideD DavideD linked an issue Jan 23, 2024 that may be closed by this pull request
@DavideD
Copy link
Member

DavideD commented Jan 23, 2024

@jponge, One of the tests fails on CI because of a NullPointerException.

It seeems related to this change: smallrye/smallrye-mutiny@bded473f#diff-5d0d520f55d5dfce2e84989c47be62de2e7b39e73c2e026fd880f0cd49977efaR83

Before there was a sub != null that has been removed. Is this a mistake?

@jponge
Copy link
Contributor Author

jponge commented Jan 23, 2024

@DavideD That's an interesting one, especially as the change was made a long time ago. I'm going to have a look.

@jponge
Copy link
Contributor Author

jponge commented Jan 23, 2024

Confirmed, there's a race-condition here 😄

@jponge jponge closed this Jan 23, 2024
@DavideD
Copy link
Member

DavideD commented Jan 23, 2024

Thanks @jponge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Mutiny to 2.5.8
2 participants