Fix liking a publication re-renders entire feed

[bigint]

Screen.Recording.2023-12-12.at.12.33.56.PM.mov

[RutamBhagat]

would like to work on this issue /attempt #4188

Options

• Cancel my attempt

[Ameer-officials]

/attempt #4188

Options

• Cancel my attempt

[algora-pbc]

Note

The user @RutamBhagat is already attempting to complete issue #4188 and claim the bounty. We recommend checking in on @RutamBhagat's progress, and potentially collaborating, before starting a new solution.

[RutamBhagat]

@bigint Is there a way to test the liking without a lens profile?

[bigint]

@RutamBhagat Try with testnet, change your env to testnet then create an account (click login -> create new account)

[bigint]

https://github.com/heyxyz/hey/blob/main/docs/development.md#create-a-lens-account-for-development

[rajdip-b]

@bigint I tried this on my device but wasn't able to reproduce the bug.

[bigint]

@rajdip-b you not seeing rerenders? can you make a short video and share 🙇🏼 ?

[RutamBhagat]

the rerenders are visible for me

[rajdip-b]

That's odd. I'm using firefox. Perhaps you can tell me where I should focus on? I was looking at the DOM tree from the inspect tab.

[bigint]

You should use react chrome extension and enable rerender paints!

[bigint]

[rajdip-b]

Ahh, okay looks like I need to switch to chrome for dev 🥲.

[RutamBhagat]

@rajdip-b search react dev tools addon

[RutamBhagat]

@rajdip-b you can work on this, I am cancelling my attempt

[rajdip-b]

@RutamBhagat sure! can you give me some insights about anything that you might have came across that is making this issue?

[rajdip-b]

@bigint is this bug localized to the "Home" section alone? or is it happening in explore aswell?

[bigint]

it happens on all feed @rajdip-b 🙇🏼

[rajdip-b]

hmmmm....lemme get to it then

[rajdip-b]

@bigint can you assign me this one please?

[rajdip-b]

@bigint hey, i seem to have fixed the issue.

it involves removing the updateCache function from apps/web/src/components/Publication/Actions/Like.tsx. but i am unsure about the side effects of this. rest assured, the app looks and performs like it is supposed to. care to give it a look?

alternatively, my understanding is, the application is listening to cache updates. and so, updating the cache makes the entire thing re-render.

[bigint]

@rajdip-b the cache is intended to update values across components

Here is the example, both are different comp but we update it 😉

Screen.Recording.2023-12-12.at.7.02.57.PM.mov

[rajdip-b]

checked this component aswell, the entire component is re-rendering. is this expected?

@rajdip-b the cache is intended to update values across components

Here is the example, both are different comp but we update it 😉
Screen.Recording.2023-12-12.at.7.02.57.PM.mov

[bigint]

It is expected to rerender only the count but not the complete publication 🙇🏼

[rajdip-b]

got it

[rajdip-b]

Hey @bigint, I don't know if I am seeing this correct, but I really feel that there is no re-rendering going on. I added a console log to the publication component that will execute every single time the component was rendered. And as I expected, only those components were re-rendered where I was liking/unliking.

Check the logs section, might give you the idea about what I am saying.
Screencast from 12-12-23 07:32:15 PM IST.webm

Another point being, re-renders occur when we have duplicate/no keys of list items. But that's not the case in here:

[bigint]

Interesing, lemme try it

[Praveen-das]

Just checking the issue and come to the same conclusion . Even if the Feed component get rerendered, only the publication component needs rerendering got rerendered.

[GauravBurande]

/attempt #4188

Options

• Cancel my attempt

[GauravBurande]

It looks like no one is working on this issue. can I work on this?