Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard location.reload or hard navigate everywhere #4182

Open
bigint opened this issue Dec 11, 2023 · 19 comments
Open

Remove hard location.reload or hard navigate everywhere #4182

bigint opened this issue Dec 11, 2023 · 19 comments

Comments

@bigint
Copy link
Member

bigint commented Dec 11, 2023

Make sure we clear all local cache while logging out!

This excludes IndexStatus.tsx

@bigint
Copy link
Member Author

bigint commented Dec 11, 2023

/bounty $80

@neo773
Copy link
Contributor

neo773 commented Dec 11, 2023

Can I get assigned?

@bigint
Copy link
Member Author

bigint commented Dec 11, 2023

@neo773 update the description 🙇🏼

@RutamBhagat
Copy link

RutamBhagat commented Dec 11, 2023

/attempt #4182

Options

@neo773 neo773 mentioned this issue Dec 11, 2023
2 tasks
@Anil56
Copy link

Anil56 commented Dec 28, 2023

/attempt #4182

Options

1 similar comment
@aadil-01
Copy link

aadil-01 commented Jan 4, 2024

/attempt #4182

Options

aadil-01 added a commit to aadil-01/hey that referenced this issue Jan 4, 2024
@aadil-01 aadil-01 mentioned this issue Jan 4, 2024
5 tasks
@kesh-007
Copy link

Is the issue still open ?

@bigint
Copy link
Member Author

bigint commented Jan 28, 2024

Yes @kesh-007

@Deb-cybe
Copy link

Deb-cybe commented Jan 28, 2024

/attempt #4182

@Deb-cybe
Copy link

/attempt #4182

@Deb-cybe Deb-cybe mentioned this issue Jan 28, 2024
@MohakBajaj
Copy link

MohakBajaj commented Jan 31, 2024

/attempt #4581

@bigint bigint changed the title Remove hard location.reload everywhere Remove hard location.reload or hard navigate everywhere Feb 3, 2024
@adevinwild
Copy link

adevinwild commented Feb 4, 2024

Hi @bigint 👋

I'd like to try and tackle this task, it will be my first time on Hey project but I need more information so let's recap very quickly.

If I've understood the problem correctly, when I log out the page has to reload in order to reset the cache. (current behavior)

What you'd like is, instead of having a page that reloads, invalidate the client-side cache without having to reload the page, thus updating all the UI components.

For example, I'm on a post page and I've put a like with my profile
When I log out, the like should disappear BECAUSE I'm no longer logged in, so I'm back to the initial state.

Is this what you are looking for ?

Nota bene : I'm currently having issues with the tesnet to create an account, I'm on the Discord at the moment trying to find a solution

@bigint
Copy link
Member Author

bigint commented Feb 4, 2024

exactly @adevinwild

@adevinwild
Copy link

Ok, then I think I can offer you a solution as soon as I have access to the testnet, which will allow me to test that everything is running smoothly on the user side.

Otherwise, I'm waiting for the implementation you mentioned here we talked about testnet sign up here: #4596 (comment)

Best regards, Adil

@bigint
Copy link
Member Author

bigint commented Feb 5, 2024

@adevinwild you can create test account here https://testnet.tape.xyz/

@adevinwild
Copy link

Thanks, I'll look into it, my idea at the moment is that following a logout action the Apollo cache should be completely erased as well as the states of the various Zustand stores that should be reset to their default values (I'm thinking of the currentProfile for example)

@adevinwild
Copy link

/attempt #4182

@jayprakash25
Copy link

Can I work on this?

@adevinwild
Copy link

Can I work on this?

I canceled my attempt on Algora 👍
Good luck, on my side it was impossible to get any replies on Discord from bigint/yoginth, I had one last point before finishing, you can take inspiration from what I did in the PR I think 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

10 participants