Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] hostname check for according to RFC1178 #4341

Open
thorvaldhrafn opened this issue Mar 28, 2024 · 6 comments
Open

[Feature] hostname check for according to RFC1178 #4341

thorvaldhrafn opened this issue Mar 28, 2024 · 6 comments
Labels
feature New feature or request

Comments

@thorvaldhrafn
Copy link

thorvaldhrafn commented Mar 28, 2024

Describe the feature or change in detail

Please, add possibility to pass this check or add some new popularity domains like .io or .co to this check.
This breaks autodeploy tasks when new server hostname is from this first levels domains.
Panel may be installed manually then with another hostname and change it later, but why it can not be possible to be added in install script?

Would you like to sponsor this feature to have it implemented?

No

@thorvaldhrafn thorvaldhrafn added the feature New feature or request label Mar 28, 2024
@jaapmarcus
Copy link
Member

You can provide any hostname:
bash hst-install.sh --hostname dev.hestiacp.com

It checks if the domain has 2 . in it any other valid works fine

@thorvaldhrafn
Copy link
Author

Yes, if I do it manually, but I do it with Ansible playbook. And it looks like bash hst-install.sh --hostname {{ansible_hostname}}. Yes, exists some methods for avoiding this problem, but I want to have not any problem with clear installation.

@Skamasle
Copy link
Contributor

Hi

This is an error in your playbook, command not exapand var correctly

Try with:

bash hst-install.sh --hostname {{ ansible_hostname }}

@jaapmarcus
Copy link
Member

Yes, if I do it manually, but I do it with Ansible playbook. And it looks like bash hst-install.sh --hostname {{ansible_hostname}}. Yes, exists some methods for avoiding this problem, but I want to have not any problem with clear installation.

set-hostname {{ ansible_hostname }}

Before running installer in Hestia ...

@thorvaldhrafn
Copy link
Author

Yes, exists many ways to avoid this, but I wrote this feature request to fix that problem, not asks for help how to avoid it.

@jaapmarcus
Copy link
Member

There is a check if the hostname provided contains at least 2 dots. Doesn't matter if it isn't server.domain.io or any.thing.localhost

So I don't understand why it should change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants