Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Eorror with Metrics #1129

Closed
jiangben opened this issue Nov 9, 2023 · 2 comments
Closed

Test Eorror with Metrics #1129

jiangben opened this issue Nov 9, 2023 · 2 comments

Comments

@jiangben
Copy link

jiangben commented Nov 9, 2023 •
edited

.\match_common_test.go:56:18: cannot use &testMetrics{} (value of type *testMetrics) as Metrics value in argument to NewLocalMatchRegistry: *testMetrics does not implement Metrics (missing method GaugeStorageIndexEntries)
.\matchmaker_test.go:1658:181: cannot use metrics (variable of type *testMetrics) as Metrics value in argument to NewRuntime: *testMetrics does not implement Metrics (missing method GaugeStorageIndexEntries)
@maciejmrozinski
Copy link
Contributor

I added fixes for this in my PR: #1128

@zyro
Copy link
Member

zyro commented Nov 12, 2023

Fixed in 2f18823 ahead of the 3.19.0 release.

@zyro zyro closed this as completed Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zyro @maciejmrozinski @jiangben