Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't process sources from nix store? #24

Open
roberth opened this issue Sep 18, 2019 · 0 comments
Open

Don't process sources from nix store? #24

roberth opened this issue Sep 18, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@roberth
Copy link
Member

roberth commented Sep 18, 2019

Store paths are typically already freshly fetched clean repos

Advantages:

  • no interference from ~/.gitconfig etc
  • smaller code path footprint for projects that use dependencies that use gitignore
  • performance

Disadvantages:

  • what if the repo gitignores some of its own contents...

Requirements:

Unresolved:

  • Where to implement this logic?
  • Should this be implemented here or in pkgs.cleanSourceWith?
@roberth roberth added the enhancement New feature or request label Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant