Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test fail: Mode_switch disappeared #1560

Closed
ThibautMarty opened this issue Aug 26, 2023 · 2 comments · Fixed by #1561
Closed

Test fail: Mode_switch disappeared #1560

ThibautMarty opened this issue Aug 26, 2023 · 2 comments · Fixed by #1561

Comments

@ThibautMarty
Copy link

The nixpkgs' herbstuftwm build fails on this test:

herbstluftwm/tests/test_keybind.py

Lines 180 to 189 in d6be492

def test_complete_keybind_offers_additional_mods_without_duplication(hlwm):
complete = hlwm.complete('keybind Mod2+Mo', partial=True, position=1)
assert set(complete) == {
'Mod2+Mod1+',
'Mod2+Mod3+',
'Mod2+Mod4+',
'Mod2+Mod5+',
'Mod2+Mode_switch ',
}

The line Mod2+Mode_switch is missing in the completion output.

I bisected nixpkgs' history and I think [1] the culprit is NixOS/nixpkgs#241220.
Besides, these commits correspond to the point when the build failed in our CI.

Could you try to run the tests with the latest X libraries to check if the issue is on our side or not?
Thanks.

[1] because bisecting nixpkgs may need mass rebuilds that I tried to avoid, so I couldn't test thoroughly.
@ThibautMarty ThibautMarty mentioned this issue Aug 26, 2023
Closed
@ThibautMarty
Copy link
Author

To be more specific, the problem seems to be related to xkeyboard-config.
Related issue:

t-wissmann added a commit that referenced this issue Aug 30, 2023
@t-wissmann
Discard 'Mode_switch' from test about modifiers
7f2eac2 
The keysym 'Mode_switch' is irrelevant for one of the completion test,
but makes it fail on newer X library versions. Thus, it is better to
just disregard it in the test case.

This fixes #1560.
@t-wissmann t-wissmann mentioned this issue Aug 30, 2023
Merged
@t-wissmann
Copy link
Member

Hi, thanks for reporting the issue!
The same issue is on arch linux with a recent X version. The failing test case actually verifies something different (see comment in the PR #1561 diff), so the best fix is to just disregard the Mode_switch completion.

@mergify mergify bot closed this as completed in #1561 Aug 30, 2023
mergify bot pushed a commit that referenced this issue Aug 30, 2023
@t-wissmann
Discard 'Mode_switch' from test about modifiers (#1561)
1a6e8ee 
The keysym 'Mode_switch' is irrelevant for one of the completion test, but makes it fail on newer X library versions. Thus, it is better to just disregard it in the test case.

This fixes #1560.
@timokau timokau mentioned this issue Sep 4, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Discard 'Mode_switch' from test about modifiers herbstluftwm/herbstluftwm
2 participants
@ThibautMarty @t-wissmann