Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't works for sin(x) #698

Open
preetishkakkar opened this issue Jan 3, 2024 · 2 comments
Open

Doesn't works for sin(x) #698

preetishkakkar opened this issue Jan 3, 2024 · 2 comments

Comments

@preetishkakkar
Copy link

sin(x) should be ~ x for small values of x, but it seems like it doesn't work, can you please help me understand.

https://herbie.uwplse.org/demo/bb8aaeebcc7ce514f73105a07cbb932fc62b16fa.10eb16397304ba9e003d59ffd34803200ce7cfa6/graph.html

@wags-1314
Copy link
Collaborator

You are right, sin(x) is equal to x for small values of x, and this is how sin(x) behaves in most math libraries too. That's why I think, as this is the default behavior of the sin function herbie does not find any rewrites.

@preetishkakkar
Copy link
Author

preetishkakkar commented Jan 4, 2024

I don't understand. What do you mean by because of default behavior herbie doesn't find rewrite?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants