Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include curl options when using curl in download function #28

Merged
merged 1 commit into from
May 10, 2024

Conversation

ssb-incomas
Copy link
Contributor

@ssb-incomas ssb-incomas commented May 9, 2024

Hi,

When using this plugin to install dotnet I ran into an issue where it didn't find any releases. I discovered that in order to access the GitHub url in the RELEASES_URI variable it requires the -L option for curl in order to follow redirects.

I could simply have added the -L flag but when reading the script I noticed the curl_opts variable already existed so I decided to use that for the release list download.

@hensou
Copy link
Owner

hensou commented May 10, 2024

Thanks a lot for your contribution @ssb-incomas , somehow I missed that curl_opts was already defined there, so it makes total sense to use it instead.

@hensou hensou merged commit 28750fe into hensou:main May 10, 2024
4 checks passed
@ssb-incomas ssb-incomas deleted the patch-1 branch May 13, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants