Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title, Confirm and Cancel in Dark mode is not visible #720

Open
theDevSoham opened this issue Oct 31, 2023 · 8 comments
Open

Title, Confirm and Cancel in Dark mode is not visible #720

theDevSoham opened this issue Oct 31, 2023 · 8 comments

Comments

@theDevSoham
Copy link

Describe the bug
Only tested on android: The dark mode text for the calendar is not changing color with theme change.

Expected behavior
To be set to white when in dark mode or preferably should take a customizalbe React.Fragment instead of a string

To Reproduce
Add example code that reproduces the behavior.

export default class App extends Component {

  state = { date: new Date() }

  render = () =>
    <DatePicker
                modal
                open={true}
                date={state }
                onConfirm={(d) => {
                  console.log("Date changed: ", d)
                }}
                onCancel={() => {
                  console.log("Cancelled: ")
                }}
                theme="dark"
                title="Select Date"
              />

}

Smartphone (please complete the following information):

  • OS: [Android]

  • React Native version [e.g. 0.67.3]

  • react-native-date-picker version [e.g. 4.3.3]

  • For Light mode:

image

  • For Dark mode:

image

@theDevSoham
Copy link
Author

@henninghall please check

@brandon-austin-lark
Copy link

Same issue here

@cyrilmarceau
Copy link

Same issue but only on google device. I have tested on a samsung s10e and problem will not appear

@pranjal-easy-peasy
Copy link

We've had to work around this by using theme="light" but it would be great to get this fixed.

@theDevSoham
Copy link
Author

theme="light" actually works fine...there's only some issue with dark mode heading and bottom buttons. It really needs some fix.

@z1haze
Copy link

z1haze commented Dec 8, 2023

This same issue exists for me with the date picker fields. This can be seen in #734

@mkhoussid
Copy link

Is there a planned fix or we might as well fork this repo and do it ourselves?

@henninghall
Copy link
Owner

PRs are welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants