Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is recommended method of overriding dependent chart default values? #4505

Closed
schollii opened this issue Aug 21, 2018 · 3 comments
Closed

Comments

@schollii
Copy link

schollii commented Aug 21, 2018

Output of helm version:
2.8 and 2.9

Output of kubectl version:
2.10 and 2.11

Cloud Provider/Platform (AKS, GKE, Minikube etc.):
AWS EC2 (with kops)

Say a chart A depends on a chart B, so it lists B in its requirements.yaml. Chart A also defines a values.yaml for A default values. Chart B exists in a repo, the chart contains a values.yaml that provides B default values for the chart, and cannot be edited. Finally, some values of Chart B need to be overridden, even root values:

# chart B values.yaml provides B defaults:
someRootVar: someValue

and

# chart A values.yaml, attempt to override B defaults: 
B:
    someRootVar: someOtherValue

This does not work. How to override B's someRootVar so it has value someOtherValue instead of someValue, either via A's values.yaml, or by adding an extra values files that helm knows is to override B defaults?

@schollii
Copy link
Author

So I found this example, mentioned in the docs: https://github.com/sapcc/helm-charts/blob/master/system/sentry/values.yaml. This suggests that you can put the chart's name as root element in A's values.yaml, and children of that root element will automatically override B's values. If this is true, where is this approach documented in the helm docs?

@cilindrox
Copy link

I think you're looking for this

That section also discusses the use of a global shared namespace which creates coupling, but might be useful in some scenarios.

@schollii
Copy link
Author

schollii commented Aug 24, 2018

Yes it is thx. I think the title is confusing, I skipped it when I skimmed the page. I suggest section title should be "Overriding a child chart's values", which focusses on the problem (user space) rather than solution (dev space - ie put special key in parent chart - that's one of many solutions namely the one that was implemented in helm!).

Laski added a commit to Laski/helm that referenced this issue Jan 29, 2019
As stated by @schollii in helm#4505 (comment) "Overriding Values from a Parent Chart" is unclear. This changes that text to "Overriding Values of a Child Chart". See @scholli's comment for justification.
Laski added a commit to Laski/helm that referenced this issue Jan 29, 2019
As stated by @schollii in helm#4505 (comment) "Overriding Values from a Parent Chart" is unclear. This changes that text to "Overriding Values of a Child Chart". See @scholli's comment for justification.

Signed-off-by: Laski <nlascano@eryx.co>
Laski added a commit to Laski/helm that referenced this issue Jan 29, 2019
As stated by @schollii in helm#4505 (comment) "Overriding Values from a Parent Chart" is unclear. This changes that text to "Overriding Values of a Child Chart". See @scholli's comment for justification.

Signed-off-by: Nahuel Lascano <nlascano@eryx.co>
bacongobbler pushed a commit that referenced this issue Jan 29, 2019
As stated by @schollii in #4505 (comment) "Overriding Values from a Parent Chart" is unclear. This changes that text to "Overriding Values of a Child Chart". See @scholli's comment for justification.

Signed-off-by: Nahuel Lascano <nlascano@eryx.co>
eraac pushed a commit to eraac/helm that referenced this issue Mar 21, 2019
As stated by @schollii in helm#4505 (comment) "Overriding Values from a Parent Chart" is unclear. This changes that text to "Overriding Values of a Child Chart". See @scholli's comment for justification.

Signed-off-by: Nahuel Lascano <nlascano@eryx.co>
Signed-off-by: Kevin Labesse <kevin@labesse.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants