Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --set-value flag that requires less escaping #4406

Closed
kvolkovich-sc opened this issue Jul 31, 2018 · 3 comments
Closed

Add --set-value flag that requires less escaping #4406

kvolkovich-sc opened this issue Jul 31, 2018 · 3 comments
Labels
feature v3.x Issues and Pull Requests related to the major version v3

Comments

@kvolkovich-sc
Copy link

Output of helm version:

Client: &version.Version{SemVer:"v2.9.1", GitCommit:"20adb27c7c5868466912eebdf6664e7390ebe710", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.9.1", GitCommit:"20adb27c7c5868466912eebdf6664e7390ebe710", GitTreeState:"clean"}

Hello!

I like Helm, but this issue does not give me rest.

According to: https://docs.helm.sh/using_helm/#the-format-and-limitations-of-set

Sometimes you need to use special characters in your --set lines. You can use a backslash to escape the characters; --set name="value1,value2" will become:

name: "value1,value2"

I can't guarantee that some value contains or not contains the comma.
So I forced to escape each value at my CI.
Its absolutely uncomfortable.

As I understand, you don't want to break compatibility for 2.x.
You can consider to introduce another CLI parameter.

  • -s
  • -S
  • --set-value
  • ... or something like this.

Related issues I found:

@technosophos
Copy link
Member

I'm re-marking this as a feature request, and re-titling it appropriately.

@technosophos technosophos changed the title Can't --set any value with comma within Add --set-value flag that requires less escaping Aug 3, 2018
@Nowaker
Copy link

Nowaker commented Aug 23, 2018

Or alternatively, make --set not treat , in a special way when --disable-the-damn-coma is passed. One way or another, how things are now is extremely inconvenient. Hope this can get straightened up. :)

CC @bacongobbler

@bacongobbler bacongobbler added this to the Upcoming - Major milestone Oct 3, 2018
@bacongobbler bacongobbler added v3.x Issues and Pull Requests related to the major version v3 and removed v3.x Issues and Pull Requests related to the major version v3 labels Mar 23, 2019
@bacongobbler
Copy link
Member

closing as a duplicate of #4030 so we can keep the conversation all in one place. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature v3.x Issues and Pull Requests related to the major version v3
Projects
None yet
Development

No branches or pull requests

5 participants