Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm converts integers to scientific notation even when quoted #3001

Closed
beeradb opened this issue Oct 4, 2017 · 2 comments
Closed

Helm converts integers to scientific notation even when quoted #3001

beeradb opened this issue Oct 4, 2017 · 2 comments

Comments

@beeradb
Copy link
Contributor

beeradb commented Oct 4, 2017

What happened

Our build uses git commit hashes for container tags during the build and then runs our helm chart tests using all the build containers for that specific commit. We had an instance this morning where the tag was completely numeric. As such, the tag got converted to scientific notation.

I was able to find some documentation on this at https://docs.helm.sh/chart_best_practices/#make-types-clear (thanks!), but I was surprised to find out that the behavior persists even when quoting the value when installing the chart via the CLI.

Reproducing this is simple, just run:

helm install stable/minio --set imageTag="1234567"

And observe the following status on the resulting pod: "InvalidImageName"

What I expected to happen

I understand type coercion between all these sources can be difficult. However, I would propose that if the value is quoted when using the CLI, it should be treated as a string and not an integer.

@beeradb beeradb changed the title Helm converts intigers to scientific notation even when quoted Helm converts integers to scientific notation even when quoted Oct 4, 2017
@bacongobbler
Copy link
Member

closing as a duplicate of #1707.

@jesselang
Copy link

Related to #3155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants