toToml filter converts int to float

[mattsch]

Given the following data structure in values.yaml:

config:
  bar: 9

And this in my configmap template:

data:
  telegraf-local.conf: |-
{{ .Values.config | toToml | indent 4 }}

I get this:

data:
  telegraf-local.conf: |-
    foo = 9.0

Even casting the variable via bar: !!int 9 doesn't change the behavior, can't reproduce using the toJson filter either.

[technosophos]

Which version of Helm/Tiller?

[mattsch]

Sorry, it was with 2.4.2.

…

On Fri, May 26, 2017, 18:49 Matt Butcher ***@***.***> wrote: Which version of Helm/Tiller? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2474 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAINKFjdrGt8yIL9bPx_UuH9kbwQuh7sks5r91bYgaJpZM4NioCL> .

[mlieberman85]

I'm seeing the same issue with 2.5.0

[copumpkin]

From poking around the code a bit, it seems like the YAML parser Helm is using converts YAML to JSON and then parses that. And although the YAML spec distinguishes between integers and floats, the JSON spec doesn't (as far as I can tell), so the conversion process is lossy. By the time the TOML encoder sees it, it's already a float, so it adds a decimal point to the output.

For reference, the conversion to JSON is happening here: https://github.com/ghodss/yaml/blob/73d445a93680fa1a78ae23a5839bad48f32ba1ee/yaml.go#L98

[bacongobbler]

related issue: #1707

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[johanfleury]

/reopen
/remove-lifecycle rotten

[bacongobbler]

Hey @johanfleury, if you could please open a new issue with the version of Helm and Kubernetes you are using as well as a demonstration/reproduction of the issue, that would be great. This issue was opened over two years ago and was likely fixed in #6010, so if you could try and reproduce using the canaries, that'd be great. Thanks!

[dud225]

reopened as #12987