Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm lint "--quiet" flag fix #13000

Open
blueprismo opened this issue May 3, 2024 · 2 comments
Open

Helm lint "--quiet" flag fix #13000

blueprismo opened this issue May 3, 2024 · 2 comments
Labels
bug Categorizes issue or PR as related to a bug.

Comments

@blueprismo
Copy link

The issue is pretty straightforward, I want to use the helm lint --quiet . command to check for errors during CI/CD.
But I got a bunch of [INFO] Errors which are not of my interest.

engine.go:206: [INFO] Missing required value: .Values.deployment.stage is required.
engine.go:206: [INFO] Missing required value: .Values.license_id is required.

To remove them, the helm lint --help output states:

--quiet print only warnings and errors

Which is not happening when I pass the --quiet flag. (I assume INFO is not ERROR nor WARNING).
I can bring a PR for this little change, either fix the documentation for the --help or (ideally) supress the INFO messages when the --quiet flag is set.

I am willing to provide any help or more information of any kind! Thanks in advance :)

Output of helm version:

version.BuildInfo{Version:"v3.14.2", GitCommit:"c309b6f0ff63856811846ce18f3bdc93d2b4d54b", GitTreeState:"clean", GoVersion:"go1.21.7"}

Output of kubectl version:

Client Version: v1.28.2
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3

Cloud Provider/Platform (AKS, GKE, Minikube etc.):
Doesn't apply

@yxxhero
Copy link
Member

yxxhero commented May 6, 2024

@blueprismo make sense. PR is welcome.

@yxxhero yxxhero added the bug Categorizes issue or PR as related to a bug. label May 6, 2024
@blueprismo
Copy link
Author

Hey @yxxhero , seems like the INFO level is hardcoded in https://github.com/helm/helm/blob/main/pkg/engine/engine.go#L206

If you don't mind, will add some conditional in between this line to ensure that if the quiet flag is passed do not print those messages.
Just FYI update message :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

2 participants