Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise error if there are migrations pending #58

Open
mgomes opened this issue Apr 8, 2018 · 3 comments
Open

Raise error if there are migrations pending #58

mgomes opened this issue Apr 8, 2018 · 3 comments

Comments

@mgomes
Copy link
Member

mgomes commented Apr 8, 2018

In Rails 5.x+, if migrations are pending, an error is raised and error page is shown in development.

Since we don't have an "error page" I was thinking we would just raise an error (when in development).

@mgomes mgomes added this to the 1.1 milestone Apr 8, 2018
@debasish117
Copy link
Contributor

Hi @mgomes ,

Is someone working on this enhancement ? If not, then i would like to start working on this. And what is the exact enhancement description ? According to my knowledge, i think if there are pending migrations then while starting the server it should return an error message as Migrations are pending. To resolve this issue, run: stealth db:migrate. Should the scenario be considered, if the server is already running and migration is generated, should the request be checked and display error message ? Please do correct me if i am wrong .

Thanks

@mgomes
Copy link
Member Author

mgomes commented May 30, 2018

@debasish117 thanks so much for stepping up. I updated the issue to contain a little more info. I was thinking that in development, an error would be raised if migrations were pending. But let me know if you have other suggestions.

Right now we don't do hot code reloading in development (#55). I just couldn't get that done in time for 1.0, but it's still high on my priority list. So I think just showing the error on server start may not be enough.

What do you think?

@debasish117
Copy link
Contributor

I think we can check it in the controller level too. On request we can have check, if there are migrations pending then throw an error . We can have a filter to check the migrations, i think so .

@mgomes mgomes modified the milestones: 1.1, 2.0 Nov 15, 2018
@mgomes mgomes removed this from the 1.2 milestone Sep 17, 2019
@mgomes mgomes removed the enhancement label Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants