Deduplicate command names in generated LSP support doc #10563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is my contributions to the project for Issue #10316 |
pascalkuthe
reviewed
Apr 23, 2024
kirawi
reviewed
Apr 23, 2024
xtask/Cargo.toml
Outdated
There was a problem hiding this comment.
This change should be dropped
There was a problem hiding this comment.
Its not changing anything in the file, nor is it contributing to the change in the pr, therefore its best to remove the file from the commit/s. This only dirties histories of files.
There was a problem hiding this comment.
I rebased and fixup'd everything into 1 commit which drops the unneeded commits.
There was a problem hiding this comment.
It seems like those commits might have been squashed into the single commit instead - those whitespace changes are still in the diff
the-mikedavis
changed the title
kirawi
added
the
S-waiting-on-author
timothyhutz
force-pushed
the
issue-10316
branch
2 times, most recently
from
3dc1186
to
e464259
Compare
|
Ready for second peer review please. |
kirawi
reviewed
May 3, 2024
|
ready for another PR review. |
kirawi
added
S-waiting-on-review
the-mikedavis
approved these changes
May 11, 2024
|
can I get another approver pls? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using unique from itertools::Itertools function to clear out and duplicate string entries. Tested on my ARM64 Windows 11 system with mdbook and generated via xtask docgen.