Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.x: @HelidonTest / @AddConfig* Provide a config parser by type #8718

Closed
jbescos opened this issue May 2, 2024 · 1 comment
Closed

4.x: @HelidonTest / @AddConfig* Provide a config parser by type #8718

jbescos opened this issue May 2, 2024 · 1 comment
Labels
4.x Version 4.x enhancement New feature or request MP P4 testing
Projects
Backlog

Comments

@jbescos
Copy link
Member

jbescos commented May 2, 2024 •
edited by romain-grecourt

Environment Details

  • Helidon Version: 4
  • Helidon MP
  • JDK version: 21

Problem Description

Both @Configuration and the newly introduced @AddConfigBlock hard-code the supported config parsers: only properties and yaml parser supported.

See #8655 (comment)

Either we need a new SPI, or update the MpConfig API to add the capability to specify config sources as a pairs of type and reader.
@github-actions github-actions bot added this to Triage in Backlog May 2, 2024
@jbescos jbescos mentioned this issue May 2, 2024
Merged
@romain-grecourt romain-grecourt changed the title 4.x: Provide a config parser by type 4.x: @HelidonTest / @AddConfig* Provide a config parser by type May 2, 2024
@romain-grecourt romain-grecourt added MP testing 4.x Version 4.x enhancement New feature or request labels May 2, 2024
@barchetta barchetta added the P4 label May 2, 2024
@barchetta barchetta moved this from Triage to Low priority in Backlog May 2, 2024
jbescos added a commit to jbescos/helidon that referenced this issue May 3, 2024
@jbescos
4.x: Provide a config parser by type helidon-io#8718
27407a0 
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
@jbescos jbescos mentioned this issue May 3, 2024
Merged
jbescos added a commit that referenced this issue May 7, 2024
@jbescos
4.x: @HelidonTest / @addconfig* Provide a config parser by type #8718 (…
9fb58b9 
…#8721)

4.x: @HelidonTest / @addconfig* Provide a config parser by type #8718

Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
@jbescos
Copy link
Member Author

jbescos commented May 13, 2024

Merged

@jbescos jbescos closed this as completed May 13, 2024
Backlog automation moved this from Low priority to Closed May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4.x Version 4.x enhancement New feature or request MP P4 testing
Projects
Backlog
  
Closed
Milestone
No milestone
Development

No branches or pull requests
3 participants
@romain-grecourt @jbescos @barchetta