Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health in 4.x does not support excluding (or including) health checks by name as 3.x does #8698

Open
tjquinno opened this issue Apr 24, 2024 · 0 comments
Assignees
Labels
4.x Version 4.x bug Something isn't working health P2
Projects

Comments

@tjquinno
Copy link
Member

tjquinno commented Apr 24, 2024

Environment Details

  • Helidon Version: 4.x
  • Helidon SE or Helidon MP
  • JDK version:
  • OS:
  • Docker version (if applicable):

Problem Description

Helidon 3.x supports config settings (or programmatic use of the builder) to exclude or include health checks by name. (Note - the documented config key for 3.x is incorrect; see #8617.)

Helidon 4 does not have this feature and its removal was not intentional.

This issue reflects the need to restore the missing feature and correct the doc's and Javadoc's usage of the incorrect config key.

Steps to reproduce

Use the Helidon 4 MP quickstart example app.

  1. Add this dependency to include the built-in health checks:
      <dependency>
            <groupId>io.helidon.health</groupId>
            <artifactId>helidon-health-checks</artifactId>
            <scope>runtime</scope>
        </dependency>
  1. Update microprofile-config.properties to include the following. (Specify both config keys to show that neither triggers the "exclude" functionality.)
helidon.health.exclude=deadlock
health.exclude=deadlock
  1. Build and run the app.
  2. Access http://localhost:8080/health; the deadlock check is still reported.
@tjquinno tjquinno added bug Something isn't working health 4.x Version 4.x labels Apr 24, 2024
@tjquinno tjquinno self-assigned this Apr 24, 2024
@tjquinno tjquinno added this to Triage in Backlog via automation Apr 24, 2024
@tjquinno tjquinno added the P2 label Apr 25, 2024
@tjquinno tjquinno moved this from Triage to High priority in Backlog Apr 25, 2024
@tjquinno tjquinno moved this from High priority to Triage in Backlog Apr 25, 2024
@m0mus m0mus moved this from Triage to High priority in Backlog Apr 25, 2024
@tjquinno tjquinno moved this from High priority to Sprint Scope in Backlog May 2, 2024
@tjquinno tjquinno moved this from Sprint Scope to In Progress in Backlog May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x bug Something isn't working health P2
Projects
Backlog
  
In Progress
Development

No branches or pull requests

1 participant