Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebClient connection is not properly returned to the pool #8683

Open
Verdent opened this issue Apr 19, 2024 · 0 comments
Open

WebClient connection is not properly returned to the pool #8683

Verdent opened this issue Apr 19, 2024 · 0 comments
Assignees
Labels
4.x Version 4.x bug Something isn't working P2 webclient
Projects
Milestone

Comments

@Verdent
Copy link
Member

Verdent commented Apr 19, 2024

Environment Details

  • Helidon Version: 4.x
  • Helidon SE or Helidon MP
  • JDK version:
  • OS:
  • Docker version (if applicable):

Problem Description

Http1ClientResponseImpl field entityFullyRead is never set to true and because of that response close method closes connection as well. If response is handled as a String, everything works as expected.

Steps to reproduce

  1. Let WebClient handle the response as JsonObject type from JSON-P
  2. Connection is always closed ofter this, even thought it is reusable.

Possible solution:

Add method close() to the ReadableEntityBase.EntityProcessedRunnable class. This method could have similar logic as ReadableEntityBase.RequestingInputStream#ensureBuffer does.

@Verdent Verdent added bug Something isn't working webclient 4.x Version 4.x labels Apr 19, 2024
@github-actions github-actions bot added this to Triage in Backlog Apr 19, 2024
@Verdent Verdent changed the title WebClient connection is not properly returned to the shared pool WebClient connection is not properly returned to the pool Apr 19, 2024
@m0mus m0mus added the P2 label Apr 22, 2024
@m0mus m0mus moved this from Triage to High priority in Backlog Apr 22, 2024
@m0mus m0mus added this to the 4.0.9 milestone Apr 22, 2024
@barchetta barchetta modified the milestones: 4.0.9, 4.1.0 May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x bug Something isn't working P2 webclient
Projects
Backlog
  
High priority
Development

No branches or pull requests

3 participants